-
Notifications
You must be signed in to change notification settings - Fork 188
[FIX] replace "e.g.," by "for example" #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Remi-Gau Before we go too far, I think we should probably verify that this is an accessibility improvement. I believe I got this recommendation from The Turing Way Style Guide, but I'm having trouble finding the justification in their reference, or other accessibility websites. It's possible that Maybe @KirstieJane (or some other representative) could clarify the situation? |
I think that the key sentence in that style guide is "eg can sometimes be read aloud as ‘egg’ by screen reading software" |
Ah, yup:
I was searching for "e.g." and "latin", so missed that. |
So is it enough to just make sure that we use "e.g." instead of "eg" (which is a typo I think we'd catch during PR review anyway)? |
I think that for non-native speakers, avoiding e.g. and using 'for example' might be more transparent. |
+1 on that, I experienced issues with that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks a bunch @Remi-Gau
I think the Turing way style guide also has a point with "etc" --> it's really seldom necessary (if ever) to use "etc" 🤔 perhaps we can remove that from the spec in another PR.
Oh no! that's going to be the source of more insomnia for me. :-p Will take care of it. :-) |
I'd suggest going ahead and merging this sooner than later, since it's semantically neutral and is going to generate merge conflicts. |
agreed. Thanks a lot @Remi-Gau |
Uh oh!
There was an error while loading. Please reload this page.