-
I'm currently adding Web API bindings to boa (e.g. WebGPU, WebAssembly). Should I contribute directly into |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 9 replies
-
TL;DR: I don't recall a scope being discussed. We always welcome contributions to Boa! So feel free to submit a PR for the features. I can't recall off the top of my head if we have ever discussed the exact scope of For background, the runtime crate specifically started out as a crate to separate out runtime specific functionality from the core ECMAScript implementation. Before this we had the console implementation directly in the engine, and it didn't make sense for that to live there. As time has passed, there have been more Web API features added to the crate, and I suspect more Web API features will be implemented over time. For me, I'm not entirely sure there is a way for us to say we will accept some of the Web API implemented over another Web API. If I'd say feel free to contribute those features to the |
Beta Was this translation helpful? Give feedback.
-
Hi @xubaiwang, I'd say if it's part of MDN one way or another (but not part of tc39), we should add it to When So basically, if you can point to the MDN as a specification / documentation of your implementation, and see that it passes some WPT (https://web-platform-tests.org/) for following the w3c standard, then it should be good enough to have a PR in boa_runtime. We have a tool already to run WPT, I can help you with that. So I agree with @nekevss, contributions welcome! |
Beta Was this translation helpful? Give feedback.
Hi @xubaiwang,
I'd say if it's part of MDN one way or another (but not part of tc39), we should add it to
boa_runtime
. For example, I'm in the process of adding web workers (includingpostMessage
, but notEventListener
yet).When
boa_runtime
is too large and causes problems to Boa's core development, we can also move it to its own repo. I remember some discussions about that.So basically, if you can point to the MDN as a specification / documentation of your implementation, and see that it passes some WPT (https://web-platform-tests.org/) for following the w3c standard, then it should be good enough to have a PR in boa_runtime. We have a tool already to run WPT, I can help you with that.
S…