Fixes tests + badge #1046
Merged
Fixes tests + badge #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a failing build on PHP 8.3 with SQLite and updates the CI status badge in the README. The build failure was caused by an uninitialized property that needed explicit initialization.
- Initializes the
$oldConfigproperty tonullto fix PHP 8.3 compatibility - Updates the CI badge format from a simple image to a clickable link
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/TestCase/Middleware/DebugKitMiddlewareTest.php | Explicitly initializes $oldConfig property to null |
| README.md | Updates CI badge from image-only to clickable link format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing build on
8.3 sqlite highestFixes bad ci status badge
Side note: Not sure why 8.4 was not failing, it should have...