DATAP-1580 - fix sass use/include deprecation warnings #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (not legacy) - Updated CRACO config to allow sass-loader library to automatically load node_modules and src paths so that Sass files are found on those paths by default, and absolute paths are not needed when importing Sass files - Updated CRACO config to use relative paths when referencing files in the components and css folders throughout the app - Made fixes to referenced Sass imports in several stylesheets based on Sass config updates - Defined true entry point stylesheet in base.scss, which holds all design system configuration and is referenced in all other stylesheets - Began updating all component stylesheets to refer to base.scss, as well as removal of unnecessary references to design system files
- Removed unnecessary references to design system folders - Added base.scss as a reference (even if not used - good to have entrypoint stylesheets in other stylesheets) - Fixed additional deprecation warnings related to file
flacoman91
changed the title
flacoman91
reviewed
Oct 29, 2024
| @@ -1,7 +1,7 @@ | |||
| @use '../../../node_modules/intro.js/introjs.css' as *; | |||
There was a problem hiding this comment.
do we need the relative path here for the intro.js css ?
There was a problem hiding this comment.
Probably not, but I kept it mainly because I didn't know much about the intro.js library.
cdmh219
deleted the
DATAP-1580-Reorder-CSS-Imports-to-Fix-Sass-Deprecation-Warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several Sass deprecation warnings were showing up in the console upon running
yarn start, and needed to be removed. In addition, several non-related tweaks were made to recent Design System / Sass Upgrade.Additions
Removals
Changes
Testing
yarn start, and check console. It should match below screenshot.yarn lintandyarn run buildto ensure that it works as previously expected, and has no errors.Screenshots
Notes
Todos
Checklist