Skip to content

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Feb 11, 2025

Adds a new example for using scipy with the Python module.

This is arguably a test only change, although the test folder is listed in the documentation.

  • start_test test/library/packages/Python/examples/scipy/ with/without gasnet

[Reviewed by @]

@jabraham17 jabraham17 force-pushed the scipy-example branch 2 times, most recently from 4b27a9a to 0b1fcac Compare February 12, 2025 21:55
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
Copy link
Member Author

I had a brainwave on this. I had been blaming many of the problems on Chapel's first-class function support. And while its partly at fault, its totally possible to make this work without better first-class function support.

You can see the difference in ef50bc6. The code was passing a FCP, getting a pointer to it, and trying to use that. But that's not really valid, because we end up getting a pointer to a local variable, and then returning that pointer out of scope. The simple fix is to hoist the creation of the pointer, so we call c_ptrTo on the original Chapel proc, not the local FCP.

@jabraham17 jabraham17 marked this pull request as ready for review August 18, 2025 19:54
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
Copy link
Member Author

Unfortunately, I am still going to have to leave this unmerged

I tested with the following, and got various forms of pass/fail

  • Works
    • fedora 42 on x86 with Chapel 2.5
    • ubuntu 24 on x86 with main
  • Fails
    • mac on arm with Chapel 2.5
    • mac on arm with main
    • SLES 15 on x86 with main

I can't explain this, but since almost all of our testing is on SLES merging this would break nightly, even though I can confirm it works on other OSes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant