(v2) A unified view interface #1426
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
CursorView
(and potentiallyViewModel
) with a simpler, more extensible API.In practice, it looks like:
Properties like the cursor and background color are optional, and
View
could be extended down the road to include other metadata, likelipgloss.Canvas
. Note that the background color should be attached to the view to avoid race conditions like we saw withtea.SetCursorPosition
.It would be my suggestion not to merge
Viewable
withModel
in order to eventually support view alternatives like the following: