Skip to content

Conversation

c-gamble
Copy link
Contributor

Description of changes

We have metrics that have unbounded cardinality on the frontend because we attach attributes like tenant, collection ID, and CRN. These may clog our otel pipeline and increase our storage costs significantly. This PR removes them.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

N/A

Observability plan

Update Honeycomb queries to not use breakdowns on corresponding terraform

Documentation Changes

N/A

@c-gamble c-gamble requested a review from codetheweb August 20, 2025 18:45
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

This PR removes the use of high-cardinality attributes (such as tenant, collection ID, and CRN) from the frontend's metrics reported to OpenTelemetry (otel). By eliminating the attachment of these dynamic attributes to metric counters, the PR aims to reduce the risk of overwhelming the otel pipeline and causing increased storage costs due to metric cardinality explosion.

This summary was automatically generated by @propel-code-bot

Copy link
Contributor Author

c-gamble commented Aug 20, 2025

2 Jobs Failed:

PR checks / all-required-pr-checks-passed

Step "Decide whether the needed jobs succeeded or failed" from job "all-required-pr-checks-passed" is failing. The last 20 log lines are:

[...]
}
EOM
)"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  GITHUB_REPO_NAME: chroma-core/chroma
  PYTHONPATH: /home/runner/_work/_actions/re-actors/alls-green/release/v1/src
# ❌ Some of the required to succeed jobs failed 😢😢😢

📝 Job statuses:
📝 python-tests → ❌ failure [required to succeed or be skipped]
📝 python-vulnerability-scan → ✓ success [required to succeed or be skipped]
📝 javascript-client-tests → ✓ success [required to succeed or be skipped]
📝 rust-tests → ✓ success [required to succeed or be skipped]
📝 go-tests → ✓ success [required to succeed or be skipped]
📝 lint → ✓ success [required to succeed]
📝 check-helm-version-bump → ⬜ skipped [required to succeed or be skipped]
📝 delete-helm-comment → ✓ success [required to succeed or be skipped]
Error: Process completed with exit code 1.
PR checks / Python tests / test-rust-bindings (3.9, chromadb/test/property/test_cross_version_persist.py)

Step "Test" from job "Python tests / test-rust-bindings (3.9, chromadb/test/property/test_cross_version_persist.py)" is failing. The last 20 log lines are:

[...]
       0.050262451171875,
       0.861328125,
       -0.8759765625,
       0.0926513671875,
       -0.5654296875,
       -0.8544921875,
       0.84228515625,
       0.82666015625,
       -0.08544921875,
       -0.041229248046875,
       -0.71240234375,
       -0.364013671875,
       0.039520263671875,
       -0.98486328125,
       0.021484375,
       0.068359375,
       0.455078125,
       -0.603515625,
       0.54052734375,
       0.9892578125,

Summary: 1 successful workflow, 1 failed workflow

Last updated: 2025-08-20 19:08:35 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant