Skip to content

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Sep 9, 2025

Description of changes

It's deprecated and migrated. Time to clean up.

That's what this PR does. It erases the k8s manifests for go logservice.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Copy link

github-actions bot commented Sep 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

github-actions bot commented Sep 9, 2025

✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to main.

@rescrv rescrv force-pushed the rescrv/no-go-log-k8s branch from 6cfe15b to 97c12b6 Compare September 9, 2025 21:17
@blacksmith-sh blacksmith-sh bot deleted a comment from rescrv Sep 9, 2025
@rescrv rescrv requested a review from jasonvigil September 9, 2025 21:54
@jasonvigil
Copy link
Contributor

⚠️ The Helm chart was updated without a version bump. Your changes will only be published if the version field in k8s/distributed-chroma/Chart.yaml is updated.

+1

@rescrv rescrv requested a review from Sicheng-Pan September 10, 2025 16:06
@rescrv rescrv force-pushed the rescrv/no-tilt-config branch from 5e1eda7 to 7c61cf4 Compare September 11, 2025 18:24
Base automatically changed from rescrv/no-tilt-config to main September 11, 2025 20:39
@rescrv rescrv force-pushed the rescrv/no-go-log-k8s branch from 97c12b6 to cff13a4 Compare September 15, 2025 19:05
Copy link
Contributor

propel-code-bot bot commented Sep 15, 2025

Remove All Kubernetes Artifacts Related to Go LogService

This pull request removes all Kubernetes manifests, configuration, build scripts, and test code related to the deprecated Go-based logservice from the repository. It cleans up Helm chart values, Tiltfile logic, docker-bake.hcl build targets, port-forwarding steps, and drops integration tests and references in configuration files, reflecting the migration to the Rust-based rust-log-service.

Key Changes

• Deleted k8s/distributed-chroma/templates/logservice.yaml (all Go logservice deployments, services, accounts, and role bindings)
• Deleted k8s/distributed-chroma/templates/log-migration.yaml (Go logservice migration Job)
• Removed logService and logServiceMigration keys from k8s/distributed-chroma/values.yaml and all related references
• Removed all Go logservice and logservice-migration build logic from Tiltfile and .github/actions/tilt-setup-prebuild/docker-bake.hcl
• Updated Tilt resource graph in Tiltfile to remove Go logservice resources and correct resource dependencies to point to rust-log-service
• Removed logservice port-forwarding in .github/actions/tilt/action.yaml
• Deleted the Rust integration test rust/log/tests/log-offsets.rs that depended on the removed Go logservice
• Removed proxy configuration for Go logservice from rust/worker/chroma_config.yaml
• Bumped version in k8s/distributed-chroma/Chart.yaml to 0.1.58

Affected Areas

k8s/distributed-chroma/templates/logservice.yaml
k8s/distributed-chroma/templates/log-migration.yaml
k8s/distributed-chroma/values.yaml
Tiltfile
rust/log/tests/log-offsets.rs
rust/worker/chroma_config.yaml
Chart.yaml
• .github/actions/tilt-setup-prebuild/docker-bake.hcl
• .github/actions/tilt/action.yaml

This summary was automatically generated by @propel-code-bot

@rescrv rescrv force-pushed the rescrv/no-go-log-k8s branch from cff13a4 to ded8e91 Compare September 15, 2025 19:51
@blacksmith-sh blacksmith-sh bot deleted a comment from rescrv Sep 15, 2025
@rescrv rescrv merged commit ecf954c into main Sep 16, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants