Skip to content

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Sep 10, 2025

Description of changes

As part of the migration from go log to wal3/rust log, we need to clean
up the old code. This PR erases the go log service in service of
cleaning up the repo.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

propel-code-bot bot commented Sep 10, 2025

Remove Go Log Service Code and Related Docker/Migrations

This PR completely removes the Go implementation of the log service from the codebase as part of the migration to the Rust-based wal3 log system. The changes include deletion of all Go log service source code, associated schema and SQL files, generated code, tests, Docker targets/images, and related database migration files. The logservice build target and Docker image are removed as well, along with configuration, metrics, purging routines, and supporting infrastructure. Only code and migration assets related to the sysdb (coordination) service remain in Go.

Key Changes

• Deleted all Go log service code: go/pkg/log/*, excluding sysdb
• Removed Go log service migrations, schemas, queries, and models
• Deleted log-related unit and property tests
• Removed Dockerfile stage and command for logservice image
• Deleted Makefile logservice build instructions
• Removed Atlas HCL/migration files and migration SQL for Go log DB
• Cleaned up supporting files (configuration, metrics, purging, utils) related to Go log
• All generated Go code from sqlc and protogen for Go log service is deleted

Affected Areas

go/pkg/log/ (except sysdb)
go/cmd/logservice/
• Makefile log targets
• Dockerfile logservice image section
go/shared/libs/db_utils.go
• Go log database migrations and schemas

This summary was automatically generated by @propel-code-bot

@@ -25,7 +25,6 @@ proto:

build: proto
go build -v -o bin/coordinator ./cmd/coordinator/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BestPractice]

The proto target still generates code for logservice.proto, but the service itself is being removed. To prevent dead code, please also remove logservice.proto from the protoc command and delete the corresponding .proto file and generated Go package (pkg/proto/logservicepb/).

Context for Agents
[**BestPractice**]

The `proto` target still generates code for `logservice.proto`, but the service itself is being removed. To prevent dead code, please also remove `logservice.proto` from the `protoc` command and delete the corresponding `.proto` file and generated Go package (`pkg/proto/logservicepb/`).

File: go/Makefile
Line: 27

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used by the rust log service. Good try, though.

@blacksmith-sh blacksmith-sh bot deleted a comment from rescrv Sep 10, 2025
@rescrv rescrv requested a review from Sicheng-Pan September 15, 2025 16:51
@rescrv rescrv force-pushed the rescrv/no-go-log-k8s branch 2 times, most recently from cff13a4 to ded8e91 Compare September 15, 2025 19:51
@rescrv rescrv changed the base branch from rescrv/no-go-log-k8s to main September 16, 2025 18:20
@rescrv rescrv force-pushed the rescrv/erase-go-log branch from 90b29eb to eb3fa7a Compare September 16, 2025 18:21
@rescrv rescrv merged commit 4299e64 into main Sep 16, 2025
58 checks passed
@rescrv rescrv deleted the rescrv/erase-go-log branch September 16, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants