-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[CLN] Remove the go log service code and Docker. #5448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Remove Go Log Service Code and Related Docker/Migrations This PR completely removes the Go implementation of the log service from the codebase as part of the migration to the Rust-based Key Changes• Deleted all Go log service code: Affected Areas• This summary was automatically generated by @propel-code-bot |
@@ -25,7 +25,6 @@ proto: | |||
|
|||
build: proto | |||
go build -v -o bin/coordinator ./cmd/coordinator/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BestPractice]
The proto
target still generates code for logservice.proto
, but the service itself is being removed. To prevent dead code, please also remove logservice.proto
from the protoc
command and delete the corresponding .proto
file and generated Go package (pkg/proto/logservicepb/
).
Context for Agents
[**BestPractice**]
The `proto` target still generates code for `logservice.proto`, but the service itself is being removed. To prevent dead code, please also remove `logservice.proto` from the `protoc` command and delete the corresponding `.proto` file and generated Go package (`pkg/proto/logservicepb/`).
File: go/Makefile
Line: 27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used by the rust log service. Good try, though.
cff13a4
to
ded8e91
Compare
90b29eb
to
eb3fa7a
Compare
Description of changes
As part of the migration from go log to wal3/rust log, we need to clean
up the old code. This PR erases the go log service in service of
cleaning up the repo.
Test plan
CI
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A