linters: enable mirror linter

Reports wrong mirror patterns of bytes/strings usage.

Signed-off-by: Mahe Tardy <[email protected]>

Author: mtardy

.golangci.yml

@@ -17,6 +17,7 @@ linters:
     - intrange
     - makezero
     - misspell
+    - mirror
     - revive
     - staticcheck
     - unused

pkg/bench/trace_bench_open.go

@@ -99,7 +99,7 @@ spec:
 	}
 	defer f.Close()
 
-	f.Write([]byte(tmpl))
+	f.WriteString(tmpl)
 	return f.Name()
 }
 

pkg/observer/observertesthelper/observer_test_helper.go

@@ -635,7 +635,7 @@ func WriteConfigFile(fileName, config string) error {
 	if err != nil {
 		return err
 	}
-	if _, err := out.Write([]byte(config)); err != nil {
+	if _, err := out.WriteString(config); err != nil {
 		return err
 	}
 	return out.Sync()

pkg/vmtests/vmtests.go

@@ -84,9 +84,9 @@ func printProgress(f *os.File, done <-chan struct{}) {
 
 		case <-ticker.C:
 			if i%10 == 0 {
-				f.Write([]byte("m"))
+				f.WriteString("m")
 			} else {
-				f.Write([]byte("."))
+				f.WriteString(".")
 			}
 			f.Sync()
 		}