linters: enable perfsrpint linter

Checks that fmt.Sprintf can be replaced with a faster alternative.

Signed-off-by: Mahe Tardy <[email protected]>

Author: mtardy

.golangci.yml

@@ -18,6 +18,7 @@ linters:
     - makezero
     - misspell
     - mirror
+    - perfsprint
     - revive
     - staticcheck
     - unused

api/vendor/github.com/cilium/tetragon/pkg/matchers/timestampmatcher/timestampmatcher.go

@@ -364,7 +364,7 @@ func (c *SyscallsIDsCmd) Run() error {
 			"git", "archive",
 			"--remote=git://sourceware.org/git/glibc.git",
 			//"HEAD:sysdeps/unix/sysv/linux/aarch64",
-			fmt.Sprintf("HEAD:%s", glibcLoc),
+			"HEAD:" + glibcLoc,
 			"--", "arch-syscall.h",
 			"|",
 			"tar", "xv", "-C", abiTmpDir},

cmd/dump-syscalls-info/main.go

@@ -4,7 +4,7 @@
 package common
 
 import (
-	"fmt"
+	"strconv"
 	"testing"
 )
 
@@ -25,7 +25,7 @@ func TestHumanizeByteCount(t *testing.T) {
 		{12970000000000, "12.97 TB"},
 	}
 	for _, tt := range tests {
-		t.Run(fmt.Sprintf("%d", tt.input), func(t *testing.T) {
+		t.Run(strconv.Itoa(tt.input), func(t *testing.T) {
 			if got := HumanizeByteCount(tt.input); got != tt.want {
 				t.Errorf("HumanizeByteCount(%d) = %v, want %v", tt.input, got, tt.want)
 			}

cmd/tetra/common/utils_test.go

@@ -95,7 +95,7 @@ func detectBpffs() (string, error) {
 		}
 		return path, nil
 	}
-	return "", fmt.Errorf("bpffs mount not found")
+	return "", errors.New("bpffs mount not found")
 }
 
 func detectLib() (string, error) {
@@ -107,7 +107,7 @@ func detectLib() (string, error) {
 		}
 		return path, nil
 	}
-	return "", fmt.Errorf("lib directory mount not found")
+	return "", errors.New("lib directory mount not found")
 }
 
 func NewProgsCmd() *cobra.Command {
@@ -329,7 +329,7 @@ func getAllProgs(lib string) ([]*prog, error) {
 
 		prog, ok := coll.Programs["iter"]
 		if !ok {
-			initErr = fmt.Errorf("can't file iter program")
+			initErr = errors.New("can't file iter program")
 			return
 		}
 		initProg, initErr = prog.Clone()

cmd/tetra/debug/progs.go

@@ -4,6 +4,7 @@
 package loglevel
 
 import (
+	"errors"
 	"fmt"
 
 	"github.com/cilium/tetragon/api/v1/tetragon"
@@ -54,7 +55,7 @@ func New() *cobra.Command {
 	  tetra loglevel set info`,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			if len(args) != 1 {
-				return fmt.Errorf("usage: tetra loglevel set [trace|debug|info|warning|error|fatal|panic]")
+				return errors.New("usage: tetra loglevel set [trace|debug|info|warning|error|fatal|panic]")
 			}
 			levelStr := args[0]
 			levelParsed, err := logrus.ParseLevel(levelStr)

cmd/tetra/loglevel/loglevel.go

@@ -4,7 +4,6 @@
 package main
 
 import (
-	"fmt"
 	"path/filepath"
 
 	"github.com/cilium/little-vm-helper/pkg/runner"
@@ -32,7 +31,7 @@ type RunConf struct {
 
 func (rc RunConf) testImageFilename() string {
 	if ext := filepath.Ext(rc.vmName); ext == "" {
-		return fmt.Sprintf("%s.qcow2", rc.vmName)
+		return rc.vmName + ".qcow2"
 	}
 	return rc.vmName
 }

cmd/tetragon-vmtests-run/conf.go

@@ -22,15 +22,15 @@ func (fs *virtIOFilesystem) vmMountpoint() string {
 }
 
 func (fs *virtIOFilesystem) qemuArgs() []string {
-	fsId := fmt.Sprintf("%s_id", fs.id)
-	tag := fmt.Sprintf("%s_tag", fs.id)
+	fsId := fs.id + "_id"
+	tag := fs.id + "_tag"
 	return []string{
 		"-fsdev", fmt.Sprintf("local,id=%s,path=%s,security_model=none", fsId, fs.hostdir),
 		"-device", fmt.Sprintf("virtio-9p-pci,fsdev=%s,mount_tag=%s", fsId, tag),
 	}
 }
 
 func (fs *virtIOFilesystem) fstabEntry() string {
-	tag := fmt.Sprintf("%s_tag", fs.id)
+	tag := fs.id + "_tag"
 	return fmt.Sprintf("%s\t%s\t9p\ttrans=virtio,rw\t0\t0\n", tag, fs.vmdir)
 }

cmd/tetragon-vmtests-run/filesystems.go

@@ -4,7 +4,6 @@
 package main
 
 import (
-	"fmt"
 	"path/filepath"
 
 	"github.com/cilium/little-vm-helper/pkg/runner"
@@ -19,7 +18,7 @@ func buildQemuArgs(log *logrus.Logger, rcnf RunConf) ([]string, error) {
 			rcnf.KernelAppendArgs = append(rcnf.KernelAppendArgs, "systemd.unified_cgroup_hierarchy=0")
 		}
 		if rcnf.useTetragonTesterInit {
-			rcnf.KernelAppendArgs = append(rcnf.KernelAppendArgs, fmt.Sprintf("init=%s", TetragonTesterBin))
+			rcnf.KernelAppendArgs = append(rcnf.KernelAppendArgs, "init="+TetragonTesterBin)
 		}
 	}
 

cmd/tetragon-vmtests-run/qemu.go

@@ -5,6 +5,7 @@ package main
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io/fs"
 	"net"
@@ -746,7 +747,7 @@ func startExporter(ctx context.Context, server *server.Server) error {
 	finfo, err := os.Stat(filepath.Clean(option.Config.ExportFilename))
 	if err == nil && finfo.IsDir() {
 		// Error if exportFilename points to a directory
-		return fmt.Errorf("passed export JSON logs file point to a directory")
+		return errors.New("passed export JSON logs file point to a directory")
 	}
 	logFile := filepath.Base(option.Config.ExportFilename)
 	logsDir, err := filepath.Abs(filepath.Dir(filepath.Clean(option.Config.ExportFilename)))