Watcher: fix NODE_NAME if missing #2824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkg/reader/node package gets the value of the NODE_NAME environment variable (if the HUBBLE_NODE_NAME is empty). If it is empty, it gets the hostname and uses that. The pkg/watcher package just attempts to get the NODE_NAME environment variable and warns that it will not work as expected if it is empty or missing. This commit changes pkg/watcher so that it uses pkg/reader/node's function instead. Signed-off-by: Kevin Sheldrake <[email protected]>
kevsecurity
added
the
release-note/misc
ghost
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkg/reader/node package gets the value of the NODE_NAME environment variable (if the HUBBLE_NODE_NAME is empty). If it is empty, it gets the hostname and uses that. The pkg/watcher package just attempts to get the NODE_NAME environment variable and warns that it will not work as expected if it is empty or missing. This commit changes pkg/watcher so that it uses pkg/reader/node's function instead.