tetragon/windows: Compilation only change for pkg/metrics/syscallmetrics #3530
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adding stub function to compile metrics package on Windows Signed-off-by: Anadi Anadi <[email protected]>
ExceptionalHandler
force-pushed
the
build/windows/raw_syscall_metrics
branch
from
6671543 to
8a8503b
Compare
olsajiri
added
the
release-note/minor
| // SPDX-License-Identifier: Apache-2.0 | ||
| // Copyright Authors of Tetragon | ||
|
|
||
| package syscallmetrics |
There was a problem hiding this comment.
are there syscalls on windows ? no idea ;-)
if we need syscallmetrics package in windows then I think the syscallmetrics.Handle should have _windows/_linux versions, the generic version is now checking for raw_syscalls/sys_enter which will not happen on windows
There was a problem hiding this comment.
This is a compilation only change. We cannot remove the syscallmetrics code from Windows without impacting compilation of common code. Goland does not have #ifdef based conditional compilation, so we need stub packages to compile common code. .
There was a problem hiding this comment.
ok, understood, I just think it'd make more sense to me to do that with syscallmetrics.Handle than with rawSyscallName
There was a problem hiding this comment.
yes, I considered that but this approach minimizes code duplication, which is the approach we agreed upon in team meeting. This is the smallest change to to let the package compile n Windows.
We cannot rule out use of syscallmetrics in Windows in the future entirely, so stubbing out the whole package might not be the best approach.
Also we already committed raw_syscall_name_linux.go, wouldn't want to walk back on that....
Description
Adding stub function to compile metrics package on Windows
Changelog