e2e: port forwarding fixes #3555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been multiple port-forwarding failures for e2e tests in CI. Indeed, this is easy to reproduce locally by running the followng test a few times: ``` $ go test -p 1 -parallel 1 -timeout 20m -count 1 -test.v \ ./tests/e2e/tests/skeleton \ -tetragon.install-cilium=false \ -tetragon.helm.version="v1.4.0" ``` The problem is that port-forwading fails at a point where we cannot recover. What happens is: * tests wait for the tetragon daemonset to be ready * then, the test port-forwards all the ports * then, the test tries to connect to the local gRPC port * the port-forwader tries to connect to the pod address * if tetragon has not reached the point where it listens to the gRPC port, the port-forwarder fails and is destroyed. This commit modifies the port forwarding code so that it also tries to connect to the gRPC port. If it cannot, the port-fowarding will fail and we retry. It also improves on the previous code that checks for the connection to change by checking all possible states. There is an innefficiency in the current version that we connect two times: one as part of port-forwading and one in the connection multiplezer. This will be addressed in the next patch. Signed-off-by: Kornilios Kourtis <[email protected]>
The previous commit established a gRPC connection when we do the port-forwarding. This ensured that the port-forwrding will not fail if the tetragon agent is not ready when something tries to connect. This commit uses the existing connections instead of redoing them. The connections are closed when the test is done. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added
release-note/ci
kkourt
changed the title
will-isovalent
approved these changes
Mar 25, 2025
kkourt
added
backport-done/1.4
backport-done/1.3
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix e2e tests port-forwarding issues.
See commits.