Skip to content

Conversation

ExceptionalHandler
Copy link
Contributor

Description

This PR compiles and ports process cache into Windows. The only difference on Windows is how the pid for cache is computed. Currently on Windows, we are not using ktime as an input into process identifier.
The PID re-use is not a very big problem on Windows and the current bpf program does not communicate the parent's ktime to usermode.
So the cache pid on windows is based on numeric PID issued by kernel.

Changelog

Compile and port the pkg/process package into Windows

This PR compiles and ports process cache into Windows. The only difference on Windows is how the pid for cache is computed.
Currently on Windows, we are not using ktime as an input into process identifier.
The PID re-use is not a very big problem on Windows and the current bpf program does not communicate the parent's ktime to usermode.
So the cache pid  on windows is based on numeric PID issued by kernel.

Signed-off-by: Anadi Anadi <[email protected]>
@ExceptionalHandler ExceptionalHandler added the release-note/misc This PR makes changes that have no direct user impact. label Apr 1, 2025
@ExceptionalHandler ExceptionalHandler requested a review from a team as a code owner April 1, 2025 23:20
Copy link
Contributor

@jrfastab jrfastab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats nice lots of good code reuse here.

@jrfastab jrfastab merged commit 86f4cf1 into cilium:main Apr 2, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants