-
Notifications
You must be signed in to change notification settings - Fork 454
tetragon/windows: Add windows compile as a ci step #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon/windows: Add windows compile as a ci step #3611
Conversation
8eb0c76
to
9f2d5f5
Compare
Makefile.windows
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, why don't you use the existing facilities with a new GOOS (like with GOARCH) or something like that? I'm not sure to understand why we need a whole new Makefile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course that is the easy change.
I am following precedent set by how tetra.exe is built for Windows and Darwin.
Also, a new make file lets us add packaging and ebpf building targets later without disrupting other makefiles.
.github/workflows/static-checks.yaml
Outdated
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
||
- name: Build tetragon Windows binaries | ||
run: make tetragon-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just doing GOOS=windows make tetragon
should build tetragon for windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you got inspired by the CLI thing. I would favor the existing build target we have for tetragon. wdyt?
.github/workflows/static-checks.yaml
Outdated
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
||
- name: Build tetragon Windows binaries | ||
run: make tetragon-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest this instead of creating a new Makefile, please also add ./tetragon.exe
just after ./tetragon
in the clean:
target.
run: make tetragon-windows | |
run: | | |
GOOS=windows GOARCH=amd64 make tetragon | |
GOOS=windows GOARCH=arm64 make tetragon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made this change.
9f2d5f5
to
596020a
Compare
This PR adds a CI step to cross compile tetragon.exe for Windows on Linux. Signed-off-by: Anadi Anadi<[email protected]>
596020a
to
810c26f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, also:
please also add ./tetragon.exe just after ./tetragon in the clean: target
I imagine you can do as a followup, no big deal
Description
This PR adds a CI step to cross compile tetragon.exe for Windows on Linux.