Refactor Pod watcher #3652
Merged
Refactor Pod watcher #3652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export DeletedPodCache so that controller-runtime manager in pkg/manager [^1] can use it with its pod informer. [^1]: #3643 Signed-off-by: Michi Mutsuzaki <[email protected]>
Refactor PodAccessor implementation so that controller-runtime manager can re-use the common code by passing its pod informer. There is no change in the actual logic. [^1]: #3643 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added
the
release-note/misc
mtardy
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits: