Skip to content

Conversation

tico88612
Copy link
Contributor

@tico88612 tico88612 commented Apr 30, 2025

Description

Fix Policy Library networking ssh anchor link

Changelog

@tico88612 tico88612 requested review from mtardy and a team as code owners April 30, 2025 02:41
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit abfa208
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/68118edecef71100089f8fd9
😎 Deploy Preview https://deploy-preview-3678--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tico88612 tico88612 changed the title doc: fix policy-library networking anchor link doc: fix policy-library sshd anchor link & title Apr 30, 2025
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The policy library is lacking some care I think, so thanks for that!

@mtardy mtardy added the release-note/docs This PR updates the documentation. label Apr 30, 2025
@mtardy
Copy link
Member

mtardy commented Apr 30, 2025

Mmh checkpatch see some issues on your commit description, maybe that's just a missing line between the title and sign-off, maybe that's because you are using a temporary email address, not sure. If you can modify that with git commit --amend, thank you! :)

Error: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'ChengHao Yang'
  #6: 
  Signed-off-by: ChengHao Yang
  
  Error: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'ChengHao Yang <17496418+tico886[12](https://github.com/cilium/tetragon/actions/runs/14745596024/job/41408886503?pr=3678#step:4:13)@users.noreply.github.com>'

@tico88612
Copy link
Contributor Author

@mtardy I think it's have extra newline cause parser error, could you help me approve workflows again? Thanks!

@mtardy mtardy merged commit 639dcfd into cilium:main Apr 30, 2025
5 checks passed
@tico88612 tico88612 deleted the doc/fix-anchor branch April 30, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants