Sensors: Use require over assert in tests #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the places where we have been using assert in tests, we really wanted the tests to fail at those points and not continue. In these cases, we should use require instead as it does just that. This commit changes a lot of asserts to requires. Signed-off-by: Kevin Sheldrake <[email protected]>
Most of the places where we have been using assert in tests, we really wanted the tests to fail at those points and not continue. In these cases, we should use require instead as it does just that. This commit changes a lot of asserts to requires. Signed-off-by: Kevin Sheldrake <[email protected]>
kevsecurity
added
the
release-note/misc
mtardy
approved these changes
May 22, 2025
There was a problem hiding this comment.
yeah this is especially important in the case where we have a function that can return a nul pointer and thus in the case of error, the test panics. I think this is generally done with https://github.com/Antonboom/testifylint. I might try to enable that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the places where we have been using assert in tests, we really wanted the tests to fail at those points and not continue. In these cases, we should use require instead as it does just that. This commit changes a lot of asserts to requires.