pkg/k8s: generate deepcopy function on k8s types #3765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9067213 ("k8s: Don't generate client code") removed the generation of the client code, but we were also using k8s-code-gen for generating the deepcopy code. We can keep everything clean and just reuse controller-gen to generate that code. Signed-off-by: Mahe Tardy <[email protected]>
This was generated using k8s-code-gen that was removed, the project builds fine without and since the defaulter is empty anyway, let's remove it. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added
the
release-note/misc
mtardy
requested review from
tpapagian and
michi-covalent
and removed request for
tpapagian
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9067213 ("k8s: Don't generate client code") removed the generation of the client code, but we were also using k8s-code-gen for generating the deepcopy code. We can keep everything clean and just reuse controller-gen to generate that code.