tetragon: do proper cleanup for uprobe and tracepoint sensors #3822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
2 times, most recently
from
2f22dd8 to
f567041
Compare
olsajiri
changed the title
Properly release uprobe entries when sensor is destroyed. Signed-off-by: Jiri Olsa <[email protected]>
Properly release tracepoint entries when sensor is destroyed. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
f567041 to
1d38d2c
Compare
tpapagian
approved these changes
Jun 11, 2025
mtardy
approved these changes
Jun 11, 2025
| @@ -70,15 +66,14 @@ func init() { | |||
|
|
|||
| // genericTracepoint is the internal representation of a tracepoint | |||
| type genericTracepoint struct { | |||
| tableId idtable.EntryID | |||
There was a problem hiding this comment.
nit for coherence
Suggested change
| tableId idtable.EntryID | |
| tableID idtable.EntryID |
There was a problem hiding this comment.
hum, seems like we use tableId everywhere:
pkg/sensors/tracing/genericlsm.go: tableId idtable.EntryID
pkg/sensors/tracing/generickprobe.go: tableId idtable.EntryID
pkg/sensors/tracing/generictracepoint.go: tableId idtable.EntryID
pkg/sensors/tracing/genericuprobe.go: tableId idtable.EntryID
There was a problem hiding this comment.
ok, I'll spin a follow up if we decide we want that change
kkourt
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proper cleanup for uprobe and tracepoint sensors, please see changelogs