Use Go 1.19 atomic types #3833
Merged
Use Go 1.19 atomic types #3833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
the
release-note/misc
tklauser
force-pushed
the
pr/tklauser/atomic-cleanups
branch
from
673a3ac to
570e2e6
Compare
The Go standard library provides types for atomic access since Go 1.19, see https://go.dev/doc/go1.19#atomic_types and https://pkg.go.dev/sync/atomic#pkg-types. These make working with atomically accessed variables type-safe and more ergonomic. This change also allows to get rid of the go.uber.org/atomic dependency. Signed-off-by: Tobias Klauser <[email protected]>
mtardy
reviewed
Jun 18, 2025
tklauser
force-pushed
the
pr/tklauser/atomic-cleanups
branch
from
570e2e6 to
c9c5761
Compare
Yeah, multierr should be easy enough. I'll have a look 👀 |
I think the only downside is that errors don't exactly look the same, I think we took a look at it in the past and there was something like one was going to the line and not the other when logging or something... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go standard library provides types for atomic access since Go 1.19, see https://go.dev/doc/go1.19#atomic_types and
https://pkg.go.dev/sync/atomic#pkg-types.
These make working with atomically accessed variables type-safe and more ergonomic.
This change also allows to get rid of the
go.uber.org/atomicdependency.