Skip to content

Conversation

HujinoKun
Copy link
Contributor

@HujinoKun HujinoKun commented Jul 23, 2025

Hello, 🖖

This PR adds icon section on chart.yaml file to make the CI happy with a green status 🟢

Fixes : N/A

Description

Currently, CI is issuing a warning about the helm linter because it wants to see the icon section in the Chart.yaml file.

My PR suggests adding the section to make the CI happy 👍

Without icon section :

@HujinoKun ➜ /workspaces/tetragon (helm/add-icon-section-on-chart-file) $ make -C install/kubernetes lint
make: Entering directory '/workspaces/tetragon/install/kubernetes'
docker run --rm -u 1000:1000 -v /workspaces/tetragon/install/kubernetes/tetragon:/apps -v /workspaces/tetragon/install/kubernetes/helm_lint_values_override.yaml:/helm_lint_values_override.yaml docker.io/alpine/helm:3.18.3@sha256:afb4ca77e37c03fbf8009cbe29e5c014cfb2e5b1d4afff59c1b38bcd77e03845 lint . --with-subcharts
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
make: Leaving directory '/workspaces/tetragon/install/kubernetes'

With icon section :

@HujinoKun ➜ /workspaces/tetragon (helm/add-icon-section-on-chart-file) $ make -C install/kubernetes lint
make: Entering directory '/workspaces/tetragon/install/kubernetes'
docker run --rm -u 1000:1000 -v /workspaces/tetragon/install/kubernetes/tetragon:/apps -v /workspaces/tetragon/install/kubernetes/helm_lint_values_override.yaml:/helm_lint_values_override.yaml docker.io/alpine/helm:3.18.3@sha256:afb4ca77e37c03fbf8009cbe29e5c014cfb2e5b1d4afff59c1b38bcd77e03845 lint . --with-subcharts
Unable to find image 'alpine/helm:3.18.3@sha256:afb4ca77e37c03fbf8009cbe29e5c014cfb2e5b1d4afff59c1b38bcd77e03845' locally
docker.io/alpine/helm@sha256:afb4ca77e37c03fbf8009cbe29e5c014cfb2e5b1d4afff59c1b38bcd77e03845: Pulling from alpine/helm
fe07684b16b8: Pull complete 
843ac2081151: Pull complete 
e4b4f3eb08f8: Pull complete 
Digest: sha256:afb4ca77e37c03fbf8009cbe29e5c014cfb2e5b1d4afff59c1b38bcd77e03845
Status: Downloaded newer image for alpine/helm@sha256:afb4ca77e37c03fbf8009cbe29e5c014cfb2e5b1d4afff59c1b38bcd77e03845
==> Linting .
1 chart(s) linted, 0 chart(s) failed
make: Leaving directory '/workspaces/tetragon/install/kubernetes'

@HujinoKun HujinoKun requested a review from a team as a code owner July 23, 2025 19:41
@HujinoKun HujinoKun requested a review from will-isovalent July 23, 2025 19:41
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Jul 24, 2025
This PR adds icon section on chart.yaml file to make the CI happy with a green status

Signed-off-by: Quentin <[email protected]>
@HujinoKun HujinoKun force-pushed the helm/add-icon-section-on-chart-file branch from 922ed60 to 0e7f971 Compare July 24, 2025 09:28
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mtardy mtardy merged commit d121dc1 into cilium:main Jul 24, 2025
45 checks passed
@HujinoKun HujinoKun deleted the helm/add-icon-section-on-chart-file branch July 24, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants