Skip to content

Conversation

ferhatelmas
Copy link
Member

@ferhatelmas ferhatelmas commented Mar 27, 2025

There are two KV groups and wrong team is the code owner, fixing it, then other group can be removed.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: codeowners fix
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: codeowners fix
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: codeowners fix
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: codeowners fix

Signed-off-by: ferhat elmas <[email protected]>
@ferhatelmas ferhatelmas requested a review from a team as a code owner March 27, 2025 09:30
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 5a8280f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 27, 2025
@CarmenPopoviciu CarmenPopoviciu added the skip-pr-description-validation Skip validation of the required PR description format label Mar 27, 2025
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-wrangler-8693

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8693/npm-package-wrangler-8693

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-wrangler-8693 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-workers-bindings-extension-8693 -O ./cloudflare-workers-bindings-extension.0.0.0-v80482281f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v80482281f.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-create-cloudflare-8693 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-kv-asset-handler-8693

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-miniflare-8693

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-pages-shared-8693

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-unenv-preset-8693

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-vite-plugin-8693

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-vitest-pool-workers-8693

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-workers-editor-shared-8693

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-workers-shared-8693

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14103220762/npm-package-cloudflare-workflows-shared-8693

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.0
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit a24cf19 into cloudflare:main Mar 27, 2025
24 of 31 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 27, 2025
@ferhatelmas ferhatelmas deleted the ferhat/kv-ownership branch March 27, 2025 09:50
dario-piotrowicz pushed a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants