Skip to content

Conversation

phobologic
Copy link
Member

not 100% sure I like the design, largely public/private are determined
by whether or not a NatGateway or InternetGateway is the default route.

not 100% sure I like the design, largely public/private are determined
by whether or not a NatGateway or InternetGateway is the default route.
"python-dateutil==2.6.1",
"stacker>=1.0.1",
"troposphere>=1.9.5",
"troposphere>=2.2.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary for cloudtools/troposphere#1050

Copy link
Member

@russellballestrini russellballestrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me! Would you mind putting in a doc string with some example YAML to show to use this to create a couple subnets (2 public/2 private) or maybe even paired with vpc.Vpc2?

That or maybe a separate example doc is in order.

@phobologic
Copy link
Member Author

@russellballestrini check out the latest update, I went ahead and threw an example in the conf directory.

@phobologic phobologic merged commit a845cd5 into master May 24, 2018
@phobologic phobologic deleted the simple_network_blueprint branch May 24, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants