Skip to content

[CLOUDTRUST-5523] Create a Jenkins job for this repository #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2024
Merged

[CLOUDTRUST-5523] Create a Jenkins job for this repository #2

merged 4 commits into from
Oct 23, 2024

Conversation

Xelowak
Copy link

@Xelowak Xelowak commented Oct 21, 2024

For it to work, I had to transform this repo into a go module using go mod init.

@Xelowak Xelowak self-assigned this Oct 21, 2024
@harture
Copy link

harture commented Oct 21, 2024

I have checked in the source library if there is an update.
It seems to be not actively maintained but some PR have been published.
The following one seems to make the changes to have module, ... compatible with go 1.22 but with just a few changes 👍 https://github.com/fogleman/gg/pull/194/files

Why do we need extra changes ? Could we just apply this PR ?

@basbeu
Copy link

basbeu commented Oct 22, 2024

I have checked in the source library if there is an update. It seems to be not actively maintained but some PR have been published. The following one seems to make the changes to have module, ... compatible with go 1.22 but with just a few changes 👍 https://github.com/fogleman/gg/pull/194/files

Why do we need extra changes ? Could we just apply this PR ?

I think this PR does not build. But I did not test it.

basbeu
basbeu reviewed Oct 22, 2024
View reviewed changes
context_test.go Outdated
@@ -2,20 +2,12 @@ package gg

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why we need to change that

@Xelowak Xelowak requested a review from basbeu October 23, 2024 07:04
@Xelowak Xelowak merged commit d0fbda1 into master Oct 23, 2024
3 checks passed
@Xelowak Xelowak deleted the CLOUDTRUST-5523 branch October 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basbeu basbeu basbeu approved these changes

@harture harture harture approved these changes

@fperot74 fperot74 Awaiting requested review from fperot74

Assignees

@Xelowak Xelowak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelowak @harture @basbeu