pkg/sql/logictest/tests/cockroach-go-testserver-24.3/cockroach-go-testserver-24_3_test: TestLogic_mixed_version_upgrade_preserve_ttl failed [empty connection string]

[cockroach-teamcity]

pkg/sql/logictest/tests/cockroach-go-testserver-24.3/cockroach-go-testserver-24_3_test.TestLogic_mixed_version_upgrade_preserve_ttl failed with artifacts on release-25.2 @ 3d3e3e1ddbd63b744d3d91ed1cb909f037e01586:

=== RUN   TestLogic_mixed_version_upgrade_preserve_ttl
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/9f8758413f0f8de9236ac00e0b041a26/logTestLogic_mixed_version_upgrade_preserve_ttl2998944264
    test_log_scope.go:76: use -show-logs to present logs inline
[08:23:22] --- queries start here (file: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/5172/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/logictest/tests/cockroach-go-testserver-24.3/cockroach-go-testserver-24_3_test_/cockroach-go-testserver-24_3_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/mixed_version_upgrade_preserve_ttl)
    logic.go:3171: let $initial_version = 24.3
[08:23:22] CREATE TABLE tbl (
  id INT PRIMARY KEY
) WITH (ttl_expire_after = '10 minutes');
panic: empty connection string

goroutine 61 [running]:
github.com/cockroachdb/cockroach-go/v2/testserver.(*testServerImpl).pollListeningURLFile(0xc001174e00, 0x2)
	external/com_github_cockroachdb_cockroach_go_v2/testserver/testserver.go:784 +0x718
github.com/cockroachdb/cockroach-go/v2/testserver.(*testServerImpl).StartNode.func1()
	external/com_github_cockroachdb_cockroach_go_v2/testserver/testservernode.go:152 +0x2e
created by github.com/cockroachdb/cockroach-go/v2/testserver.(*testServerImpl).StartNode in goroutine 66
	external/com_github_cockroachdb_cockroach_go_v2/testserver/testservernode.go:151 +0x11fd

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-52487

[spilchen]

I'm not quite sure where the panic: empty connection string is coming from. A string search found this issue #98612, which is from 2 years ago and was resolved with a fix. But I didn't see any comments that described what the error was.

[spilchen]

The panic comes from here:
https://github.com/cockroachdb/cockroach-go/blob/v2.4.0/testserver/testserver.go#L783-L785

This code was reworked in (and the panic removed) to have better error handling in this PR: cockroachdb/cockroach-go#181

We just don't have this in the 25.2 branch.

[spilchen]

This seems like a rare flake. Probably not worth getting a backport of testserver to the 25.2 branch.