cloud/kubernetes: update manifests and enhance security #151314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
shreyaskm623
force-pushed
the
k8s_manifests_refactor
branch
4 times, most recently
from
24331cb to
4a21e3d
Compare
shreyaskm623
force-pushed
the
k8s_manifests_refactor
branch
from
4a21e3d to
0437332
Compare
cloud/kubernetes/README.md
Outdated
| version of Kubernetes, use the files from the appropriate subdirectory (e.g. the | ||
| `v1.7` directory for Kubernetes 1.7 or the `v1.6` directory for Kubernetes 1.6). | ||
| `v1.20` directory for Kubernetes 1.7). |
There was a problem hiding this comment.
Suggested change
| `v1.20` directory for Kubernetes 1.7). | |
| `v1.20` directory for Kubernetes 1.20). |
| # TODO: Change these to appropriate values for the hardware that you're running. You can see | ||
| # the resources that can be allocated on each of your Kubernetes nodes by running: | ||
| # kubectl describe nodes | ||
| # Note that requests and limits should have identical values. |
There was a problem hiding this comment.
Why is this required? Is it mentioned somewhere in docs or other examples?
There was a problem hiding this comment.
Or maybe we can modify it as recommended as mentioned here
| @@ -191,11 +196,38 @@ spec: | |||
| - name: cockroachdb | |||
| image: cockroachdb/cockroach:@VERSION@ | |||
| imagePullPolicy: IfNotPresent | |||
| # TODO: Change these to appropriate values for the hardware that you're running. You can see | |||
There was a problem hiding this comment.
Nit: I suppose we do not need to add TODO here?
| @@ -190,13 +195,40 @@ spec: | |||
| topologyKey: kubernetes.io/hostname | |||
| containers: | |||
| - name: cockroachdb | |||
| image: cockroachdb/cockroach:v25.2.4 | |||
| image: cockroachdb/cockroach:@VERSION@ | |||
There was a problem hiding this comment.
Is @VERSION@ a placeholder?
shreyaskm623
force-pushed
the
k8s_manifests_refactor
branch
from
0437332 to
87ed564
Compare
This commit updates the Kubernetes deployment manifests by removing deprecated APIs, enhancing security with IMDSv2, improving ARM compatibility, and cleaning up legacy files. Key changes: Update PodDisruptionBudget API from policy/v1beta1 to policy/v1 Replace byrnedo/alpine-curl:0.1 with 3.20 for ARM64 support Implement IMDSv2 for secure AWS metadata access in EKS deployments Remove deprecated v1.6 and v1.7 directories (22 legacy files) Regenerate all manifest files from updated templates Release notes: none Epic: CRDB-49252
shreyaskm623
force-pushed
the
k8s_manifests_refactor
branch
from
87ed564 to
a291f46
Compare
shreyaskm623
force-pushed
the
k8s_manifests_refactor
branch
from
f01ea40 to
17f7e40
Compare
pritesh-lahoti
approved these changes
Sep 8, 2025
| @@ -47,4 +47,4 @@ spec: | |||
| restartPolicy: OnFailure | |||
| volumes: | |||
| - name: client-certs | |||
| emptyDir: {} | |||
| emptyDir: {} | |||
There was a problem hiding this comment.
nit: can retain the newline at the end of the file - also applies to other files.
|
Closing this in favor of : #153166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Kubernetes deployment manifests by removing deprecated APIs, enhancing security with IMDSv2, improving ARM compatibility, and cleaning up legacy files.
Key changes:
Release notes: none
Epic: CRDB-49252