sql: port eventlog to the information_schema #153068
Open
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of an effort to define a more stable sql interface for the introspection of cockroach specific internals, we'll port the zones table (and a number of other "production ready" crdb_internal tables) to the information_schema. The system.eventlog table is unique, in that it is the only table we plan on porting to the information_schema which is not a virtual table, and therefore should require some extra steps. Fixes: cockroachdb#149907 Epic: CRDB-24527 Release note (sql change): Adds a view to the system.eventlog in the information_schema.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an effort to define a more stable sql interface for the introspection of cockroach specific internals, we'll port the zones table (and a number of other "production ready" crdb_internal tables) to the information_schema.
The system.eventlog table is unique, in that it is the only table we plan on porting to the information_schema which is not a virtual table, and therefore should require some extra steps.
Fixes: #149907
Epic: CRDB-24527
Release note (sql change): Adds a view to the system.eventlog in the information_schema.