scripts: fix put command in gceworker.sh #153076
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#125154 we added a put command to send files to a gceworker via scp. The scp command allows for multiple source files, but it was using a scalar bash variable to hold the sourcepaths. This variable was not handling paths with spaces properly. For example: ``` % touch my\ file.txt % scripts/gceworker.sh put 'my file.txt' /usr/bin/scp: stat local "my": No such file or directory ERROR: (gcloud.compute.scp) [/usr/bin/scp] exited with return code [255]. ``` The fix is to use a bash array to hold the source paths, and to add quoting. With this fix it works correctly: ``` % touch my\ file.txt % scripts/gceworker.sh put 'my file.txt' my file.txt 100% 0 0.0KB/s 00:00 ``` Epic: None Release note: None
|
This change is |
|
(This was found from an LLM analysis of old PRs.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #125154 we added a put command to send files to a gceworker via scp. The scp command allows for multiple source files, but it was using a scalar bash variable to hold the sourcepaths. This variable was not handling paths with spaces properly. For example:
The fix is to use a bash array to hold the source paths, and to add quoting. With this fix it works correctly:
Epic: None
Release note: None