jobfrontier: change Get to accept read-only frontier #153078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
The `ReadOnlyFrontier` interface is a strict subset of `Frontier` and to reduce duplicate code, this commit redefines `Frontier` in terms of `ReadOnlyFrontier`. Release note: None
This patch changes `Get` to accept a read-only frontier to prevent any accidental modification of the passed-in frontier. Release note: None
andyyang890
force-pushed
the
20250905-read-only-frontier
branch
from
df58294 to
a78dff7
Compare
andyyang890
commented
Sep 6, 2025
| txn isql.Txn, | ||
| jobID jobspb.JobID, | ||
| name string, | ||
| frontier span.ReadOnlyFrontier, |
There was a problem hiding this comment.
One additional motivation for this change is that when we're accessing the sub-frontiers in a span.MultiFrontier, we only have a span.ReadOnlyFrontier and we'd like to be able to store the sub-frontiers with this function
andyyang890
requested review from
jeffswenson,
dt,
asg0451 and
msbutler
and removed request for
a team
msbutler
approved these changes
Sep 8, 2025
|
TFTR! bors r=msbutler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
span: redefine Frontier in terms of ReadOnlyFrontier
The
ReadOnlyFrontierinterface is a strict subset ofFrontierand to reduce duplicate code, this commit redefines
Frontierin terms of
ReadOnlyFrontier.Release note: None
jobfrontier: change Get to accept read-only frontier
This patch changes
Getto accept a read-only frontier to preventany accidental modification of the passed-in frontier.
Release note: None
Epic: None