drtprod: set ROACHPROD_GCE_DEFAULT_SERVICE_ACCOUNT to match ROACHPROD_GCE_DEFAULT_PROJECT #153134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srosenberg
requested review from
nameisbhaskar and
shailendra-patel
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
srosenberg
requested review from
a team,
golgeek and
DarrylWong
and removed request for
a team
|
This change is |
…_GCE_DEFAULT_PROJECT Minor tweak to ensure the correct default service account is set. Epic: none Release note: None
srosenberg
force-pushed
the
sr/drtprod_gce_default_service_account
branch
from
5b0cecd to
3acb837
Compare
srosenberg
changed the title
shailendra-patel
approved these changes
Sep 8, 2025
herkolategan
approved these changes
Sep 8, 2025
|
TFTR! bors r=shailendra-patel,herkolategan |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak to ensure the correct default
service account is set.
Epic: none
Release note: None