Skip to content

Conversation

D3Hunter
Copy link

@D3Hunter D3Hunter commented Jan 16, 2025

Support build on loong64.
loong64 or Loongson (龙芯) is the name of a family of general-purpose, MIPS
architecture-compatible, later in-house LoongArch architecture microprocessors

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@D3Hunter
Copy link
Author

@jbowens @RaduBerinde could you help review this? or give some feedback on how to contribute to this repo.

@RaduBerinde
Copy link
Member

Thanks! Normally I'd say to fix it on master and then backport to release-1.1 and release-2.0. But this is no longer needed on master (as of #4227). I will merge this, can you open the same PR against release-2.0?

@RaduBerinde
Copy link
Member

Can you give your comment a decent description? E.g. manual: support loong64

@D3Hunter D3Hunter changed the title support build on loong64 manual: support loong64 Jan 17, 2025
@D3Hunter
Copy link
Author

comment changed, just found out that 2.0 has been fixed by #3631

original description, with useful links

Loongson (simplified Chinese: 龙芯; traditional Chinese: 龍芯; pinyin: Lóngxīn; lit. 'Dragon Core') is the name of a family of general-purpose, MIPS architecture-compatible, later in-house LoongArch architecture microprocessors

@RaduBerinde
Copy link
Member

The commit itself just says "change".

Support build on loong64.
loong64 or Loongson (龙芯) is the name of a family of general-purpose, MIPS
architecture-compatible, later in-house LoongArch architecture microprocessors
@D3Hunter
Copy link
Author

D3Hunter commented Jan 20, 2025

The commit itself just says "change".

sorry, I get used to another paradigm that will squash my commits and use PR title as commit message. I amend the commit message, ptal

@RaduBerinde RaduBerinde merged commit 5dd133a into cockroachdb:pebble-release-1.1 Jan 20, 2025
@D3Hunter D3Hunter deleted the loong64 branch January 21, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants