refactor: shared function for constructing llm api #7563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sestinj
requested review from
tomasz-stefaniak
and removed request for
a team
dosubot
bot
added
the
size:L
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| orgScopeId: organizationId, | ||
| proxyUrl: undefined, // TODO | ||
| proxyUrl: (model as any).onPremProxyUrl ?? undefined, |
There was a problem hiding this comment.
Could you add a stricter type here?
tomasz-stefaniak
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor: shared function for constructing llm api
Summary by cubic
Centralized LLM API construction with a new createLlmApi(model, auth) helper and updated ModelService to use it. This removes duplicated logic, standardizes continue-proxy handling (org scope and on‑prem proxy), and simplifies tests.
Refactors
Dependencies