feat(oauth): use asExternalUrl to get the correct callback #7651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the hardcoded localhost from #6800 with using
asExternalUrl
to support configuration in more complex environmentsAI Code Review
@continue-general-review
or@continue-detailed-review
Checklist
Screen recording or screenshot
asExternalUrl.mov
Tests
Updated
core/context/mcp/MCPOauth.vitest.ts
to ensure use ofgetExternalUri
when available, and fallback to the oldlocalhost:3000
when it isn't, and some (limited) concurrency tests.Summary by cubic
Switch OAuth redirects to use IDE external URLs (VS Code asExternalUri) instead of hardcoded localhost, so callbacks work in local, remote, and web environments. Adds state-based concurrency and safer server handling.
New Features
Bug Fixes