Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Sep 10, 2025

Description

Added tests for skipping telemetry when there is no internet connnection which was introduced in #7528

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Add unit tests to ensure the CLI skips telemetry when offline. Tests mock dns/promises to simulate no internet, verify hasInternetConnection caching/refetch, and confirm getClient returns undefined when offline.

@uinstinct uinstinct requested a review from a team as a code owner September 10, 2025 14:04
@uinstinct uinstinct requested review from tingwai and removed request for a team September 10, 2025 14:04
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 12, 2025
@RomneyDa RomneyDa merged commit 162e00f into continuedev:main Sep 12, 2025
66 of 70 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants