-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: improve compaction UI, show compaction message as status message #7695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Code ReviewAI review failed due to service initialization issues. Please check the Continue API key and configuration. No specific line comments generated. 💡 To request a new detailed review, comment |
a4ca79e
to
e2f3c44
Compare
e2f3c44
to
d74fde6
Compare
d74fde6
to
f951269
Compare
Introduces ActionStatus component and refactor normal loading message into ActionStatus
f951269
to
54846d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review now
); | ||
expect(mockCallbacks.onSystemMessage).toHaveBeenCalledWith( | ||
"✓ Chat history auto-compacted successfully.", | ||
"Chat history auto-compacted successfully.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed checkmarks to be consistent with other system messages, we don't use check marks anywhere else
@@ -1,3 +1,5 @@ | |||
/* eslint-disable max-lines */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried refactoring useChat.ts
to reduce line numbers but it got way too messy, would be better to tackle that another time / PR
Did something similar here: #7541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice tests
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Previously compaction messages were not very clear and would disappear when its done compacting so I've
ActionStatus
component so that when it is compacting there's an animation so users won't think its stuck/compact
slash command now also uses this new component/compact
is calledFor video demo purposes I've set my compaction threshold extremely low so every new message causes a compaction.
Screen.Recording.2025-09-11.at.10.35.44.AM.mov