Skip to content

Conversation

masonkatz
Copy link
Contributor

Full discussion in issue #422

  • go back to inferring the tabSize
  • keep indentSize unchanged

I've been running this for several days in Go and Python.

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 28, 2025

Didn't you also say that indentSize is redundant?

@masonkatz
Copy link
Contributor Author

I believe that indentSize is not used, but may have been at one time.

  • tabSize can be found as a variable in the language server .js code (also in the .map file).

  • indentSize does not exist in the server .js code -- but it is in the .map file.

  • While it is not in the copilot.vim code it does appear in the xcode (also from github) version.

To be conservative I kept it in.

Which makes more sense?

  1. take it out
  2. add a comment saying it is suspected to be unused

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 29, 2025

Add a comment so we won't forget to investigate this further down the road.

@masonkatz
Copy link
Contributor Author

PR updated

@bbatsov bbatsov merged commit 4f51b3c into copilot-emacs:main Jun 30, 2025
13 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 30, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants