Skip to content

Use empty() instead of isset() to check for empty arrays in RootComposer (test coverage 100%) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2019
Merged

Use empty() instead of isset() to check for empty arrays in RootComposer (test coverage 100%) #265

merged 1 commit into from
Apr 9, 2019

Conversation

ElijahLynn
Copy link
Contributor

This gets RootComposer to full coverage.

@ElijahLynn ElijahLynn changed the title Use empty() instead of isset() to check for empty arrays. Use empty() instead of isset() to check for empty arrays in RootComposer (test coverage 100%) Apr 9, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 39.716% when pulling d66c5a4 on ElijahLynn:fix-coverage-rootcomposer into 007a886 on cweagans:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 39.716% when pulling d66c5a4 on ElijahLynn:fix-coverage-rootcomposer into 007a886 on cweagans:master.

@cweagans cweagans merged commit fc8a477 into cweagans:master Apr 9, 2019
@ElijahLynn
Copy link
Contributor Author

https://www.php.net/manual/en/types.comparisons.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElijahLynn @coveralls @cweagans