chore(wait): add types and fix issues flagged by types #32332
Merged
+85
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jennifer-shehane
requested review from
AtofStryker
and removed request for
jennifer-shehane
AtofStryker
approved these changes
Sep 15, 2025
| return checkForXhr.apply(window, [alias, type, index, num, options]) | ||
| }, | ||
| // TODO: What should `_log`'s type be? | ||
| // @ts-expect-error - Incompatible types. |
There was a problem hiding this comment.
I think a lot of this has to do with a mismatch between the internal log and external log type. Could be we just update the declaration types but it isn't likely worth the effort since it isn't consumer facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I’m not certain all of the types are correct, but I’m confident most are.
I’ve left some
TODOs with questions that hopefully someone can answer.Steps to test
Check for type errors in your IDE.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?