Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Sep 3, 2025

  • Closes N/A

Additional details

This is a feature branch and all the commits in it have been reviewed. Converts all the tests in the CLI to vitest from mocha and refactors some of the source code to be more readable

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker self-assigned this Sep 3, 2025
* chore: cut over exec directory to vitest

* Update cli/test/lib/exec/run.spec.ts

* Update cli/test/lib/exec/run.spec.ts

* Update cli/test/lib/exec/run.spec.ts
change way verify module is exported due to issues interpreting module (thinks its an esm)

rework scripts as we cannot run an empty mocha suite

chore: fix snapshots and verify requires that are internal to the cypress project

fix stubbing issues with fs-extra which is also used by request-progress under the hood

fix issues where xvfb was stopping prematurely
@AtofStryker AtofStryker changed the title DRAFT: convert CLI tests to vitest chore: convert CLI tests to vitest Sep 12, 2025
@AtofStryker AtofStryker marked this pull request as ready for review September 12, 2025 17:51
cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Sep 12, 2025

cypress    Run #65478

Run Properties:  status check passed Passed #65478  •  git commit a825b22091: chore: fix CLI tests (#32484)
Project cypress
Branch Review feature/cli_to_vitest
Run status status check passed Passed #65478
Run duration 20m 39s
Commit git commit a825b22091: chore: fix CLI tests (#32484)
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 791
View all changes introduced in this branch ↗︎
UI Coverage  63.16%
  Untested elements 26  
  Tested elements 48  
Accessibility  98.98%
  Failed rules  0 critical   3 serious   1 moderate   0 minor
  Failed elements 19  

@AtofStryker
Copy link
Contributor Author

merging this in as the underlying commits are approved through review

ryanthemanuel pushed a commit that referenced this pull request Sep 15, 2025
* chore: updating v8 snapshot cache

* index on develop: 31ee30b chore: convert CLI tests to vitest  (#32416)

* index on develop: 31ee30b chore: convert CLI tests to vitest  (#32416)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
ryanthemanuel pushed a commit that referenced this pull request Sep 15, 2025
* chore: updating v8 snapshot cache

* index on develop: 31ee30b chore: convert CLI tests to vitest  (#32416)

* index on develop: 31ee30b chore: convert CLI tests to vitest  (#32416)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
ryanthemanuel pushed a commit that referenced this pull request Sep 15, 2025
* chore: updating v8 snapshot cache

* index on develop: 31ee30b chore: convert CLI tests to vitest  (#32416)

* index on develop: 31ee30b chore: convert CLI tests to vitest  (#32416)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant