Issues with linq2db tests

[MaceWindu]

Similar to #73 I'm trying to evaluate if it makes sense to have support for custom expression compiler in linq2db.

Right now we have a lot of tests that fail with exceptions, hangs or incorrect results. I've used custom build using version from master branch as we need signed assembly to run our tests.

Does it make sense to create issue for each failure or you can try to run our tests and fix issues you receive?

Linq2db version with required changes is available here: linq2db/linq2db#1277

To run tests you will need to create test configuration file UserDataProviders.json (as copy of DataProviders.json) and comment-out all databases from NET45 test configuration to run generic non-database tests. This will give you 10 failing tests.

After that you can uncomment providers one-by-one to run database tests. Those are sqlite/access tests, so they don't need any extra environment setup.

If you want, I can invite you to our slack chat to have faster communication.

[dadhi]

If you want, I can invite you to our slack chat to have faster communication.

Not for this week, I am on vacation.

Does it make sense to create issue for each failure or you can try to run our tests and fix issues you receive?

Won't be able to run your tests, at least for a couple of weeks. But may be someone else can? /cc @dzmitry-lahoda

May be, there is a similar error in a group of tests. So you can create less than 10 issues.

Otherwise, start one by one, better with isolated failed test. The tests for issues can be added to FastExpressionCompiler.IssueTests project. See already added tests for example. You should initially Ignore the failing tests. PR is welcome.

[dzmitry-lahoda]

@MaceWindu, hopefully you could create FastExpressionCompiler.IssueTests.Issue83_Linq2db with all tests extracted from linq2db. This greatly reduces barrier of occasional fixes and increases chances somebody from the wild will look into, problem defined and covered. May be part of tests to start work at - by fixing these chances others will go away.

As of now I am not interested in digging and running linq2db, until I will find, and I search often, devs for local hackaton and who wants get in touch with ORM.

[MaceWindu]

Ok, but don't think I will be able to look at it before weekend

[jogibear9988]

This Code reproduces one issue....

    [Test]
    public void ConvertTest()
    {
        var pParam = Expression.Parameter(typeof(string), "p");

        var condition = Expression.Condition(Expression.NotEqual(pParam, Expression.Constant(null, typeof(string))),
            Expression.Convert(pParam, typeof(int), typeof(int).GetMethod("Parse", new[] {typeof(string)})),
            Expression.Constant(0));
        var lambda = Expression.Lambda<Func<string, int>>(condition, pParam);
        var convert1 = FastExpressionCompiler.ExpressionCompiler.CompileFast(lambda, true);
        var convert2 = lambda.Compile();

        var p = "10";
        var c1 = convert1(p);
        var c2 = convert2(p);

        Assert.AreEqual(c1, c2);
    }

[jogibear9988]

Seems like this

 Expression.Convert(pParam, typeof(int), typeof(int).GetMethod("Parse", new[] {typeof(string)}))

is not yet supported!

[dadhi]

@jogibear9988 ,

Yep, Convert with method is not supported yet. It may be the first easy step to do add support in FEC. There is a failing test to help in @MaceWindu PR.

Honestly, I was surprized to see that Convert may accept a method. Why even to provide such an API, if you have a direct method call. Sigh :-(

[jogibear9988]

@dadhi I haven't seen, he already created tests .. ;-(.

[jogibear9988]

for nullable char, maybe this is helpful

https://stackoverflow.com/questions/10888820/initializing-a-nullable-type-with-initobj-opcode-in-il