Skip to content

Conversation

ruggishop
Copy link
Contributor

Summary

This PR fixes two issues with the Agent Marketplace page:

  1. Bookmark button no longer requires an active conversation - Previously, the bookmark navigation component required a conversation object from the Recoil store, preventing it from functioning on pages without an active chat (like the marketplace).
Before After
1  before 1  after
  1. Fixed React context access in Agent Marketplace - The MarketplaceProvider was being rendered inside the component that needed to consume it, causing context hook errors; these errors caused the New Chat button to be unresponsive (with a NPE error in the console) when clicked from the Agent Marketplace page. Moved the provider to wrap the component at the route level.
Before After
2  before 2  after

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Test Process:

  1. Navigate to /agents or /agents/:category routes
  2. Verify the bookmark button dropdown opens and displays available bookmarks
  3. Verify the new chat button creates a new conversation
  4. Confirm no React context errors in the console
  5. Test that bookmark filtering still works as expected

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@ruggishop ruggishop marked this pull request as ready for review September 10, 2025 16:56
@ruggishop ruggishop changed the base branch from main to dev September 10, 2025 16:58
@danny-avila danny-avila changed the title fix: Agent Marketplace Bookmark and New Chat buttons 🔖 fix: Agent Marketplace Bookmark and New Chat buttons Sep 10, 2025
@danny-avila danny-avila merged commit 31445e3 into danny-avila:dev Sep 10, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants