[Internal] Make plugin framework implementation of share resource as default #4967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
…4965) ## Changes <!-- Summary of your changes that are easy to understand --> Plugin framework implementation of share resource is not compatible with SDKv2. Compatibility difference arises because of how these libraries apply the changes internally: Plugin Framework checks if the state is null for creation: https://github.com/hashicorp/terraform-plugin-framework/blob/main/internal/fwserver/server_applyresourcechange.go#L47 ````go // If PriorState is missing/null, its a Create request. if req.PriorState == nil || req.PriorState.Raw.IsNull() {...} ```` Whereas SDKv2 checks the ID: https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/schema/resource.go#L976 ````go if data.Id() == "" { // We're creating, it is a new resource. ... } ```` Because of the incompatibility, SDKv2 re-creates the share resource after it has been created by plugin framework. The PR adds the ID field as part of schema. This change makes the plugin framework implementation compatible with SDKv2 ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - Integration tests - Also E2E tested for applying share resource in SDKv2 after it's been applied by plugin framework in: #4967 --------- Co-authored-by: vuong-nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOCKED
To be merged after: #4965 and #4969
Changes
Make the plugin framework implementation of share resource as default. With this change,
databricks_sharewill use the plugin framework implementation.Tests
Integration tests