fix(docs): update usage_stats optionality #14659
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
kevinkarchacryl
commented
Sep 4, 2025
| @@ -107,7 +107,7 @@ shows up correctly after datashare consumer namespace is ingested. | |||
|
|
|||
| ### Profiling | |||
|
|
|||
| Profiling runs sql queries on the redshift cluster to get statistics about the tables. To be able to do that, the user needs to have read access to the tables that should be profiled. | |||
| Profiling runs sql queries on the redshift cluster to get statistics about the tables. In order to do that, the user needs to have read access on the tables that should be profiled. | |||
There was a problem hiding this comment.
This change isn't needed, I was just making sure that changes were going to this page https://docs-website-dg2mt4evv-acryldata.vercel.app/docs/generated/ingestion/sources/redshift/
| @@ -143,7 +143,7 @@ | |||
| @capability(SourceCapability.SCHEMA_METADATA, "Enabled by default") | |||
| @capability( | |||
| SourceCapability.USAGE_STATS, | |||
| "Enabled by default, can be disabled via configuration `include_usage_statistics`", | |||
| "Optionally enabled via `include_usage_statistics`", | |||
There was a problem hiding this comment.
This change does not show up on https://docs-website-dg2mt4evv-acryldata.vercel.app/docs/generated/ingestion/sources/redshift/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset Usage not actually enabled by default for redshift.