-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(web): extended incidents graphql apis to return more context #14671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Meticulous spotted visual differences in 156 of 1534 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit b206df5. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 2.3kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (3.84%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
@@ -1,3 +1,5 @@ | |||
#import "./incident.graphql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
priority: optional int = 0 | ||
priority: optional int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this a potentially backward incompatible change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually a bug, nobody would want this to default like this. It's optional anyways so not breaking anything
No description provided.