Skip to content

Conversation

purnimagarg1
Copy link
Collaborator

@purnimagarg1 purnimagarg1 commented Sep 5, 2025

Linear ticket:
https://linear.app/acryl-data/issue/CH-734/manage-summary-permissions-allow-you-to-edit-docs-fe-and-be

Description:

This PR considers the newly added manageAssetSummary permission and allows editing of documentation and links when the user has this permission.

Bringing PR back to OSS

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 5, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Sep 5, 2025
Copy link

alwaysmeticulous bot commented Sep 5, 2025

🔴 Meticulous spotted visual differences in 20 of 1380 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 3e23d95. This comment will update as new commits are pushed.

Copy link

codecov bot commented Sep 5, 2025

Bundle Report

Changes will increase total bundle size by 8.45kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.57MB 8.45kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 8.45kB 18.92MB 0.04%

Files in assets/index-*.js:

  • ./src/app/entityV2/summary/documentation/useDocumentationPermission.ts → Total Size: 447 bytes

  • ./src/app/entityV2/summary/links/useLinkPermission.ts → Total Size: 402 bytes

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ql/resolvers/mutate/UpdateDescriptionResolver.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@purnimagarg1 purnimagarg1 changed the title [WIP] feat(summary-tab): use manage summary permission to allow editing documentation and links feat(summary-tab): use manage summary permission to allow editing documentation and links Sep 16, 2025
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@chriscollins3456 chriscollins3456 merged commit 3294e72 into master Sep 17, 2025
38 checks passed
@chriscollins3456 chriscollins3456 deleted the pg--ch-734-manage-summary-permission-doc-links branch September 17, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants