Skip to content

fix(ingest): profiling - memory usage reduction #5830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

fix(ingest): profiling - memory usage reduction #5830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce126c6
fix(ingest): profiling - memory usage reduction
shirshanka Sep 5, 2022
dfbf47a
move to deque
shirshanka Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,21 +747,23 @@ def generate_profiles(
"great_expectations.dataset.sqlalchemy_dataset.SqlAlchemyDataset._get_column_quantiles_bigquery",
_get_column_quantiles_bigquery_patch,
):
async_profiles = [
async_profiles = {
async_executor.submit(
self._generate_profile_from_request,
query_combiner,
request,
platform=platform,
profiler_args=profiler_args,
)
): 1
for request in requests
]
}

# Avoid using as_completed so that the results are yielded in the
# same order as the requests.
# for async_profile in concurrent.futures.as_completed(async_profiles):
for async_profile in async_profiles:
# remove from dictionary to release reference
del async_profiles[async_profile]
yield async_profile.result()

total_time_taken = timer.elapsed_seconds()
Expand Down