Skip to content

fix(ingest): include urns in rest sink failure logs #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(ingest): include urns in rest sink failure logs #5848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions metadata-ingestion/src/datahub/ingestion/sink/datahub_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,18 +175,18 @@ def _write_done_callback(
:200
]

# Include information about the entity that failed.
record = record_envelope.record
if isinstance(record, MetadataChangeProposalWrapper):
entity_id = record.entityUrn
e.info["id"] = entity_id
elif isinstance(record, MetadataChangeEvent):
entity_id = record.proposedSnapshot.urn
e.info["id"] = entity_id

if not self.treat_errors_as_warnings:
self.report.report_failure({"error": e.message, "info": e.info})
else:
record = record_envelope.record
if isinstance(record, MetadataChangeProposalWrapper):
# include information about the entity that failed
entity_id = cast(
MetadataChangeProposalWrapper, record
).entityUrn
e.info["id"] = entity_id
else:
entity_id = None
self.report.report_warning({"warning": e.message, "info": e.info})
write_callback.on_failure(record_envelope, e, e.info)
else:
Expand Down