Skip to content

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Sep 13, 2022

Closes #4029
Closes #3530

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Sep 13, 2022
@mayurinehate mayurinehate changed the title refractor(snowflake): use snowflake-beta to certified snowflake source refractor(snowflake): move snowflake-beta to certified snowflake source Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Unit Test Results (metadata ingestion)

       8 files  ±  0         8 suites  ±0   55m 43s ⏱️ +52s
   704 tests  -   5     701 ✔️  -   5  3 💤 ±0  0 ±0 
1 408 runs   - 10  1 402 ✔️  - 10  6 💤 ±0  0 ±0 

Results for commit 790dba4. ± Comparison against base commit 15a33fa.

This pull request removes 5 tests.
tests.unit.stateful_ingestion.provider.test_datahub_ingestion_reporting_provider.TestDatahubIngestionReportingProvider ‑ test_provider
tests.unit.stateful_ingestion.test_configs ‑ test_state_provider_configs[reporting_bad_config]
tests.unit.stateful_ingestion.test_configs ‑ test_state_provider_configs[reporting_default]
tests.unit.stateful_ingestion.test_configs ‑ test_state_provider_configs[reporting_valid_full_config]
tests.unit.stateful_ingestion.test_configs ‑ test_state_provider_configs[reporting_valid_simple_config]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 17s ⏱️ -35s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 790dba4. ± Comparison against base commit 15a33fa.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate force-pushed the snowflake_beta_to_snowflake branch from 7a4981a to 507aee2 Compare September 14, 2022 04:36
Copy link
Contributor

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 2558129 into datahub-project:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake database syntax Snowflake ingestion errors for schemas with more than 10k tables
3 participants